Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup lit cohabitation #4834

Merged
merged 43 commits into from
Jan 13, 2025
Merged

chore: setup lit cohabitation #4834

merged 43 commits into from
Jan 13, 2025

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Jan 7, 2025

First PR to scaffold the Lit migration, essentially #4787 without the atomic-text migration.

Mainly:

Web Dev Server

Replace the Stencil web dev server with a framework-agnostic one.
For now, it comes with degraded performance (it will need to be replaced/adapted when the transition is over)

This comes with some hack removal in the Cypress tests.

Autoloader

Setup an auto-loader for future Lit Elements, heavily inspired by Shoelace

Stencil Proxy

Proxy some files generated by Stencil to 'plug-in' what's relative to Lit.

Bikeshedding

  • CSS: ought to setup CSS building for Lit
  • Decorators & utils setup still

https://coveord.atlassian.net/browse/KIT-3861

Copy link

github-actions bot commented Jan 7, 2025

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 243 243 0
commerce 354.1 354.1 0
search 414 414 0
insight 405.3 405.3 0
recommendation 255.2 255.2 0
ssr 407.5 407.5 0
ssr-commerce 371.4 371.4 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@louis-bompart louis-bompart changed the title chore/cohab setup chore: setup lit cohabitation Jan 8, 2025
@louis-bompart louis-bompart marked this pull request as ready for review January 8, 2025 00:10
@louis-bompart louis-bompart requested review from a team as code owners January 8, 2025 00:10
Copy link
Contributor

@alexprudhomme alexprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we add TODOs for everything that was added in here that can be deleted or modified once we finish the migration ? Like a simple guide "What to clean up once we finish the migration".

packages/atomic/package.json Outdated Show resolved Hide resolved
packages/atomic/src/autoloader/index.ts Show resolved Hide resolved
@louis-bompart louis-bompart added this pull request to the merge queue Jan 13, 2025
Merged via the queue into master with commit ed66ba0 Jan 13, 2025
124 checks passed
@louis-bompart louis-bompart deleted the chore/cohab-setup branch January 13, 2025 18:47
y-lakhdar pushed a commit that referenced this pull request Jan 14, 2025
First PR to scaffold the Lit migration, essentially #4787 without the
atomic-text migration.

Mainly:

## Web Dev Server
Replace the Stencil web dev server with a framework-agnostic one.
For now, it comes with degraded performance (it will need to be
replaced/adapted when the transition is over)

This comes with some hack removal in the Cypress tests.

## Autoloader
Setup an auto-loader for future Lit Elements, heavily inspired by
Shoelace

## Stencil Proxy
Proxy some files generated by Stencil to 'plug-in' what's relative to
Lit.

# Bikeshedding

- CSS: ought to setup CSS building for Lit
- Decorators & utils setup still
y-lakhdar pushed a commit that referenced this pull request Jan 14, 2025
First PR to scaffold the Lit migration, essentially #4787 without the
atomic-text migration.

Mainly:

## Web Dev Server
Replace the Stencil web dev server with a framework-agnostic one.
For now, it comes with degraded performance (it will need to be
replaced/adapted when the transition is over)

This comes with some hack removal in the Cypress tests.

## Autoloader
Setup an auto-loader for future Lit Elements, heavily inspired by
Shoelace

## Stencil Proxy
Proxy some files generated by Stencil to 'plug-in' what's relative to
Lit.

# Bikeshedding

- CSS: ought to setup CSS building for Lit
- Decorators & utils setup still
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants