Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(atomic): replace HTMLStencilElement with HTMLElement #4835

Merged
merged 3 commits into from
Jan 14, 2025
Merged

chore(atomic): replace HTMLStencilElement with HTMLElement #4835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec91c7b
chore(atomic): replace HTMLStencilElement with HTMLElement
y-lakhdar Jan 8, 2025
b942ce6
Add generated files
Jan 8, 2025
a154d8d
Merge branch 'master' into KIT-3827
y-lakhdar Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/atomic/src/components/common/interface/bindings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import type {SearchEngine} from '@coveo/headless';
import {CommerceEngine} from '@coveo/headless/commerce';
import type {RecommendationEngine} from '@coveo/headless/recommendation';
import {HTMLStencilElement} from '@stencil/core/internal';
import {i18n} from 'i18next';
import {InsightEngine} from '../../insight';
import {AtomicCommonStore, AtomicCommonStoreData} from './store';
Expand Down Expand Up @@ -30,7 +29,7 @@ export interface CommonStencilStore<StoreData extends AtomicCommonStoreData> {
export interface CommonBindings<
Engine extends AnyEngineType,
Store extends AtomicCommonStore<AtomicCommonStoreData>,
InterfaceElement extends HTMLStencilElement,
InterfaceElement extends HTMLElement,
> {
/**
* A headless engine instance.
Expand Down Expand Up @@ -68,7 +67,7 @@ export interface NonceBindings {
export type AnyBindings = CommonBindings<
AnyEngineType,
AtomicCommonStore<AtomicCommonStoreData>,
HTMLStencilElement
HTMLElement
>;

export type AnyEngineType =
Expand Down
3 changes: 1 addition & 2 deletions packages/atomic/src/components/common/interface/interface-common.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import {LogLevel} from '@coveo/headless';
import {ComponentInterface, h} from '@stencil/core';
import {HTMLStencilElement} from '@stencil/core/internal';
import {i18n, TFunction} from 'i18next';
import Backend from 'i18next-http-backend';
import {setCoveoGlobal} from '../../../global/environment';
Expand All @@ -23,7 +22,7 @@ export interface BaseAtomicInterface<EngineType extends AnyEngineType>
iconAssetsPath: string;
logLevel?: LogLevel;
language?: string;
host: HTMLStencilElement;
host: HTMLElement;
bindings: AnyBindings;
error?: Error;

Expand Down
Loading