Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix release of headless-react typedoc #4837

Merged
merged 2 commits into from
Jan 10, 2025
Merged

chore: fix release of headless-react typedoc #4837

merged 2 commits into from
Jan 10, 2025

Conversation

alexprudhomme
Copy link
Contributor

https://coveord.atlassian.net/browse/KIT-3764

I made another tiny mistake again but for headless-react

Copy link

github-actions bot commented Jan 8, 2025

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 243 243 0
commerce 354.1 354.1 0
search 414 414 0
insight 405.3 405.3 0
recommendation 255.2 255.2 0
ssr 407.5 407.5 0
ssr-commerce 371.4 371.4 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Can we add 'sanity checks' in the CI? Can be done in another PR too
i.e. 'does the doc build' before merging smthg

@alexprudhomme
Copy link
Contributor Author

alexprudhomme commented Jan 8, 2025

LGTM: Can we add 'sanity checks' in the CI? Can be done in another PR too i.e. 'does the doc build' before merging smthg

yes there already is !

https://github.com/coveo/ui-kit/actions/runs/12675640259/job/35327626283?pr=4837

@alexprudhomme alexprudhomme added this pull request to the merge queue Jan 10, 2025
Merged via the queue into master with commit 119c611 Jan 10, 2025
95 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3764 branch January 10, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants