fix(insight): literally just a single character! #4841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikegron
requested review from
olamothe,
fpbrault,
louis-bompart and
fbeaudoincoveo
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
louis-bompart
approved these changes
Jan 9, 2025
dguerinCoveo
approved these changes
Jan 9, 2025
dmgauthier
approved these changes
Jan 9, 2025
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(insight): facet manager bindings error on disconnect callback
SVCC-4338
There was an error if you add the component to the DOM and then remove it without calling initialize on the search interface, since bindings are undefined, so I added an optional chaining operator on the facet manager disconnect callback to not have an error!
It was not a big deal but mostly annoying in ServiceNow since it displayed a huge error toast on the client side 😓