-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(atomic): migrate to Tailwind V4 #4923
base: master
Are you sure you want to change the base?
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
@@ -1,6 +1,6 @@ | |||
@import '../../../../global/global.pcss'; | |||
|
|||
@define-mixin mobile-feedback-modal { | |||
@utility mobile-feedback-modal { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced all simple mixins with custom utilities
@@ -33,17 +33,17 @@ | |||
|
|||
[part='generated-answer-feedback-modal'] { | |||
&::part(container) { | |||
@apply min-w-[42.5rem]; | |||
@apply min-w-170; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced any arbitrary values in classes when possible
@@ -1,6 +1,6 @@ | |||
@define-mixin icon-coloring $color { | |||
@utility icon-coloring-* { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixins that use one or two variables have been replaced with functional utilities
@define-mixin atomic-children-desktop $section-children, $children-tag-name, $margin-lg, $margin-sm { | ||
@import '../../../global/global.pcss'; | ||
|
||
@utility atomic-children-desktop-* { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since functional utilities can't have more than two variables (value/modifier), I had to replace the $(section-*) variables with their actual values. For now this will do but we can find a cleaner solution later if we want!
I am curious what motivated this quite major lib update in the middle of a framework transition... I would feel more secure with screen video captures of some interfaces. |
@dmgauthier It is actually part of our move to Lit, as we want to already have everything in place as we convert the components to Lit, instead of a second phase of changes later just for the upgrade to tailwind 4 |
That's an excellent question, and the concern is well-placed. The timing of the migration is a key decision factor. If we were in the middle of migration (i.e., components had already been migrated or "touched" CSS), we would have postponed the migration. You are right that if we had migrated components, we would have doubled the risk, as we would have had to check the two stacks, which would have been burdensome, and we would probably not have taken this risk. However, right now essentially:
|
Ability to replace most of our component-specific stylesheets with just tailwind classes, with the new selectors. |
@fpbrault @louis-bompart |
@fpbrault, that will probably warrant some QA steps. Try to target the areas where it's may fail and where we lack visibility |
https://coveord.atlassian.net/browse/KIT-3925