Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(quantic): Add tests for feedback modal edge cases in quanticSmartSnippet e2e tests #4939

Merged
merged 7 commits into from
Feb 10, 2025

Conversation

SimonMilord
Copy link
Contributor

@SimonMilord SimonMilord commented Feb 4, 2025

SFINT-5933

IN THIS PR:

  • Added the following 2 edge cases tests in the smart snippet E2E tests in playwright:

1- when trying to open the feedback modal after executing a query that gave a new answer, should open the feedback modal
2- when trying to open the feedback modal after executing the same query, should not allow to open the feedback modal

I check the presence of the explain why button which opens the feedback modal, this was the check in the Cypress ones.

TESTS:

image

@SimonMilord SimonMilord marked this pull request as ready for review February 4, 2025 20:58
@SimonMilord SimonMilord requested a review from a team as a code owner February 4, 2025 20:58
Copy link

github-actions bot commented Feb 4, 2025

Pull Request Report

PR Title

❌ Title should follow the conventional commit spec:
<type>(optional scope): <description>

Example: feat(headless): add result-list controller

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244 244 0
commerce 355.3 355.3 0
search 415.2 415.2 0
insight 406.4 406.4 0
recommendation 256.2 256.2 0
ssr 409 409 0
ssr-commerce 373 373 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, just a bunch of red lines for failing tests?

@mmitiche
Copy link
Contributor

mmitiche commented Feb 6, 2025

@SimonMilord the PR title should be changed to test(quantic):...
this will allow a proper versioning of the library.

@SimonMilord SimonMilord changed the title feat(SFINT-5933): Add tests for feedback modal edge cases in quanticSmartSnippet e2e tests test(SFINT-5933): Add tests for feedback modal edge cases in quanticSmartSnippet e2e tests Feb 6, 2025
@SimonMilord SimonMilord changed the title test(SFINT-5933): Add tests for feedback modal edge cases in quanticSmartSnippet e2e tests test(quantic): Add tests for feedback modal edge cases in quanticSmartSnippet e2e tests Feb 6, 2025
Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SimonMilord SimonMilord added this pull request to the merge queue Feb 10, 2025
Merged via the queue into master with commit 08648b4 Feb 10, 2025
101 checks passed
@SimonMilord SimonMilord deleted the SFINT-5933 branch February 10, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants