-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(quantic): Add tests for feedback modal edge cases in quanticSmartSnippet e2e tests #4939
Conversation
2efde5d
to
56b20eb
Compare
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect, just a bunch of red lines for failing tests?
packages/quantic/force-app/main/default/lwc/quanticSmartSnippet/e2e/quanticSmartSnippet.e2e.ts
Show resolved
Hide resolved
@SimonMilord the PR title should be changed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SFINT-5933
IN THIS PR:
1- when trying to open the feedback modal after executing a query that gave a new answer, should open the feedback modal
2- when trying to open the feedback modal after executing the same query, should not allow to open the feedback modal
I check the presence of the explain why button which opens the feedback modal, this was the check in the Cypress ones.
TESTS: