chore: build working again on windows #4954
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
requested review from
olamothe,
fpbrault,
y-lakhdar and
alexprudhomme
louis-bompart
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
commented
Feb 10, 2025
There was a problem hiding this comment.
Proposed upstream beenotung/fix-esm-import-path#15
There was a problem hiding this comment.
I really am not a fan of patches. I would separate this dep with renovate to make sure the main one doesn't randomly break.
fbeaudoincoveo
approved these changes
Feb 11, 2025
| @@ -0,0 +1,11 @@ | |||
| #!/usr/bin/env node | |||
fbeaudoincoveo
approved these changes
Feb 11, 2025
|
Nice PR description for a PR not in draft ! Helps a lot with the review |
Co-authored-by: Frederic Beaudoin <[email protected]>
fpbrault
force-pushed
the
building-on-windows
branch
from
6bcec4a to
3ac817a
Compare
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.