-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(headless): add has no answer state to crga state #4961
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
...s/headless/src/controllers/knowledge/generated-answer/headless-answerapi-generated-answer.ts
Outdated
Show resolved
Hide resolved
I see a bunch of e2e tests failing comments in your PRs, but all checks are passing. Is it normal? |
yeag they are not related to these changes |
Since double negation like |
packages/headless/src/features/generated-answer/generated-answer-state.ts
Outdated
Show resolved
Hide resolved
eb8b171
to
befb654
Compare
SVCC-4651
hasNoAnswer
in order to tell if an answer was generated with no answer.answerapi
orsearchui
Screen.Recording.2025-02-12.at.9.22.40.AM.mov