Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(headless): add has no answer state to crga state #4961

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

jelmedini
Copy link
Contributor

@jelmedini jelmedini commented Feb 12, 2025

SVCC-4651

  • Introduce a new state hasNoAnswer in order to tell if an answer was generated with no answer.
  • This state will be used to add a customizable sorry message slot when no answer was generated for some clients.
  • The logic was implemented to work when using answerapi or searchui
Screenshot 2025-02-13 at 3 00 58 PM
Screen.Recording.2025-02-12.at.9.22.40.AM.mov

Copy link

github-actions bot commented Feb 12, 2025

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244 244.2 0.1
commerce 355.3 355.5 0
search 415.2 415.5 0.1
insight 406.4 406.7 0.1
recommendation 256.2 256.3 0.1
ssr 409 409.3 0.1
ssr-commerce 373 373.2 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@jelmedini jelmedini changed the title feta(headless): add hasNoAnswer state to answer state feta(headless): add has no answer state to answer state Feb 12, 2025
@jelmedini jelmedini changed the title feta(headless): add has no answer state to answer state feat(headless): add has no answer state to answer state Feb 12, 2025
@jelmedini jelmedini changed the title feat(headless): add has no answer state to answer state feat(headless): add has no answer state to crga state Feb 12, 2025
@gbaril-coveo
Copy link

I see a bunch of e2e tests failing comments in your PRs, but all checks are passing. Is it normal?

@jelmedini
Copy link
Contributor Author

I see a bunch of e2e tests failing comments in your PRs, but all checks are passing. Is it normal?

yeag they are not related to these changes

@dmgauthier
Copy link
Contributor

Since double negation like hasNoAnswer = false can be a bit hard to interpret for a human (like me).
Changing hasNoAnswer to cannotAnswer would be even more clear that the model has been reached but was not able to answer.
Your logic wouldn't have to change.
cc @lbergeron

@jelmedini jelmedini added this pull request to the merge queue Feb 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2025
@jelmedini jelmedini added this pull request to the merge queue Feb 14, 2025
Merged via the queue into master with commit d1f0e7b Feb 14, 2025
125 checks passed
@jelmedini jelmedini deleted the feature/SVCC-4651 branch February 14, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants