test(atomic): styling smoke tests #4978
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
requested review from
olamothe,
y-lakhdar,
louis-bompart and
alexprudhomme
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
force-pushed
the
KIT-3966
branch
2 times, most recently
from
f08466d to
a280fab
Compare
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
| /* Test against mobile viewports. */ | ||
| // { | ||
| // name: 'Mobile Chrome', | ||
| // use: { ...devices['Pixel 5'] }, | ||
| // }, | ||
| // { | ||
| // name: 'Mobile Safari', | ||
| // use: { ...devices['iPhone 12'] }, | ||
| // }, | ||
|
|
||
| /* Test against branded browsers. */ | ||
| // { | ||
| // name: 'Microsoft Edge', | ||
| // use: { ...devices['Desktop Edge'], channel: 'msedge' }, | ||
| // }, | ||
| // { | ||
| // name: 'Google Chrome', | ||
| // use: { ...devices['Desktop Chrome'], channel: 'chrome' }, | ||
| // }, |
There was a problem hiding this comment.
The switch is to comment and uncomment parts of the config ?
We cannot do more elegant and practical than this ?
There was a problem hiding this comment.
Same as atomic-hosted-page, this is directly from the playwright config examples:
https://github.com/microsoft/playwright/blob/main/examples/todomvc/playwright.config.ts
| // Add/modify a translation | ||
| // searchInterface.i18n.addResourceBundle('en', 'translation', { | ||
| // search: 'Make me feel lucky!' | ||
| // }); | ||
|
|
||
| // Change the language of the interface dynamically | ||
| // searchInterface.language = 'fr'; | ||
|
|
||
| // Interact with the engine | ||
| // searchInterface.engine.dispatch(...); | ||
|
|
||
| // Get all translated strings for a language/namespace | ||
| // const allStrings = searchInterface.i18n.getResourceBundle('en', 'translation'); | ||
|
|
||
| // Add field value captions, using caption-[field] | ||
| // searchInterface.i18n.addResourceBundle('en', 'caption-author', { | ||
| // 'BBC News': 'The BBC', | ||
| // amoreau: 'Alexandre Moreau', | ||
| // }); |
There was a problem hiding this comment.
Is this another switch ?
There was a problem hiding this comment.
This is what we have in the main example page (index.html), themingTests.html is a duplicate of it with the only difference being a custom theme applied
|
I wonder if proper playwright visual testing https://playwright.dev/docs/test-snapshots |
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
@dmgauthier not sure how this would let us test that the colors of the variables are getting applied to the components |
This PR adds tests to ensure our components styles can be customized using our
--atomic-*css variables. Tests to verify that our styles dont escape our components have also been added.https://coveord.atlassian.net/browse/KIT-3966
https://coveord.atlassian.net/browse/KIT-3965