Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create reusable workflows #15

Merged
merged 24 commits into from
Feb 21, 2024
Merged

Create reusable workflows #15

merged 24 commits into from
Feb 21, 2024

Conversation

shenxianpeng
Copy link
Contributor

@shenxianpeng shenxianpeng commented Feb 18, 2024 •
edited
Loading

closes #14

@shenxianpeng shenxianpeng marked this pull request as ready for review February 19, 2024 15:33
@shenxianpeng shenxianpeng added the enhancement New feature or request label Feb 19, 2024
@shenxianpeng
Copy link
Contributor Author

Next, I will do some testing by calling them in the real projects

2bndy5

This comment was marked as resolved.

Sign in to view

shenxianpeng and others added 3 commits February 20, 2024 08:50
@shenxianpeng
Copy link
Contributor Author

High-quality review, very helpful 👍

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 20, 2024
@shenxianpeng
Copy link
Contributor Author

I'd like to try and get reusable workflows tested in this repository.

@2bndy5
Copy link
Contributor

2bndy5 commented Feb 20, 2024

Oh, that would require many additional files. It might be easier to test from a different repo's PR.

@2bndy5
Copy link
Contributor

2bndy5 commented Feb 20, 2024 •
edited
Loading

you can test this branch directly from another repo:

jobs:
  build_docs:
    uses: cpp-linter/.github/.github/workflows/sphinx.yml@reusable-workflows
    with:
      path-to-doc: docs/_build/html

@shenxianpeng
Copy link
Contributor Author

Yes. I give up this thought and let it be tested in other repos 🤣

@2bndy5 2bndy5 dismissed their stale review February 20, 2024 15:51

resolved

@2bndy5 2bndy5 mentioned this pull request Feb 21, 2024
Merged
@shenxianpeng shenxianpeng merged commit 0d42924 into main Feb 21, 2024
1 check passed
@shenxianpeng shenxianpeng deleted the reusable-workflows branch February 21, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2bndy5 2bndy5 2bndy5 left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating cpp-linter reusable workflows
2 participants
@shenxianpeng @2bndy5