Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added method to set signature size #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions src/main/java/org/redline_rpm/Builder.java
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,11 @@ public class Builder {
protected final Entry< byte[]> immutable = ( Entry< byte[]>) format.getHeader().addEntry( HEADERIMMUTABLE, 16);

protected Contents contents = new Contents();
protected File privateKeyRingFile;
protected String privateKeyId;
protected String privateKeyPassphrase;
protected PGPPrivateKey privateKey;
protected File privateKeyRingFile;
protected String privateKeyId;
protected String privateKeyPassphrase;
protected PGPPrivateKey privateKey;
protected int signatureSize = 287;

/**
* Initializes the builder and sets some required fields to known values.
Expand Down Expand Up @@ -1220,6 +1221,15 @@ public void setPrivateKeyPassphrase( String privateKeyPassphrase ) {
public void setPrivateKey( PGPPrivateKey privateKey ) {
this.privateKey = privateKey;
}

/**
* Sets the signature size for generating keys with different RSA headers.
* This should only be used if the exact size of the header is known.
* @param signatureSize the signature size
*/
public void setSignatureSize( int signatureSize ) {
this.signatureSize = signatureSize;
}

/**
* Generates an RPM with a standard name consisting of the RPM package name, version, release,
Expand Down Expand Up @@ -1398,9 +1408,9 @@ public void build( final FileChannel original) throws NoSuchAlgorithmException,

protected SignatureGenerator createSignatureGenerator() {
if (privateKey != null) {
return new SignatureGenerator( privateKey );
return new SignatureGenerator( privateKey, signatureSize );
}
return new SignatureGenerator( privateKeyRingFile, privateKeyId, privateKeyPassphrase);
return new SignatureGenerator( privateKeyRingFile, privateKeyId, privateKeyPassphrase, signatureSize );
}

protected byte[] getSignature( final int count) {
Expand Down
12 changes: 7 additions & 5 deletions src/main/java/org/redline_rpm/SignatureGenerator.java
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
*/
public class SignatureGenerator {

protected static final int SIGNATURE_SIZE = 287;
protected int signatureSize;
protected final boolean enabled;
protected Entry< byte[]> headerOnlyRSAEntry;
protected Entry< byte[]> headerAndPayloadPGPEntry;
Expand All @@ -39,12 +39,14 @@ public class SignatureGenerator {
protected Key< byte[]> headerAndPayloadKey = null;
private Logger logger = getLogger( SignatureGenerator.class.getName());

public SignatureGenerator( PGPPrivateKey privateKey ) {
public SignatureGenerator( PGPPrivateKey privateKey, int signatureSize ) {
this.privateKey = privateKey;
this.enabled = privateKey != null;
this.signatureSize = signatureSize > 0 ? signatureSize : 287;
}

public SignatureGenerator( File privateKeyRingFile, String privateKeyId, String privateKeyPassphrase ) {
public SignatureGenerator( File privateKeyRingFile, String privateKeyId, String privateKeyPassphrase, int signatureSize ) {
this.signatureSize = signatureSize > 0 ? signatureSize : 287;
if ( privateKeyRingFile != null ) {
PGPSecretKeyRingCollection keyRings = readKeyRings( privateKeyRingFile );
PGPSecretKey secretKey = findMatchingSecretKey( keyRings, privateKeyId );
Expand All @@ -63,8 +65,8 @@ public SignatureGenerator( File privateKeyRingFile, String privateKeyId, String
@SuppressWarnings("unchecked")
public void prepare( Signature signature ) {
if ( enabled ) {
headerOnlyRSAEntry = ( Entry< byte[]> ) signature.addEntry( RSAHEADER, SIGNATURE_SIZE );
headerAndPayloadPGPEntry = ( Entry< byte[]> ) signature.addEntry( LEGACY_PGP, SIGNATURE_SIZE );
headerOnlyRSAEntry = ( Entry< byte[]> ) signature.addEntry( RSAHEADER, signatureSize );
headerAndPayloadPGPEntry = ( Entry< byte[]> ) signature.addEntry( LEGACY_PGP, signatureSize );
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/redline_rpm/SignatureGeneratorTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ public class SignatureGeneratorTest extends TestBase {

@Test
public void testReadingFirstKey() throws Exception {
SignatureGenerator generator = new SignatureGenerator( new File( getFileResource( "/pgp/secring.gpg" ) ), null, "redline" );
SignatureGenerator generator = new SignatureGenerator( new File( getFileResource( "/pgp/secring.gpg" ) ), null, "redline", 287 );
assertTrue( generator.isEnabled() );
}

@Test
public void testFindByKey() throws Exception {
SignatureGenerator generator = new SignatureGenerator( new File( getFileResource( "/pgp/secring.gpg" )), "5A186608", "redline" );
SignatureGenerator generator = new SignatureGenerator( new File( getFileResource( "/pgp/secring.gpg" )), "5A186608", "redline", 287 );
assertTrue( generator.isEnabled() );
}
}