Skip to content

Commit

Permalink
remove setters from response objects, add tests
Browse files Browse the repository at this point in the history
  • Loading branch information
crazzyghost committed May 1, 2020
1 parent 127861f commit 71589ea
Show file tree
Hide file tree
Showing 18 changed files with 356 additions and 265 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -140,4 +140,5 @@ gradle
.idea/
.vscode
**/Main.java
bin/**
bin/**
*.sh
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ test.finalizedBy jacocoTestReport
dependencies {
testImplementation group: 'junit', name: 'junit', version: '4.12'
implementation 'com.squareup.okhttp3:okhttp:3.11.0'
implementation("com.squareup.okhttp3:logging-interceptor:4.5.0")
implementation 'com.squareup.okhttp3:logging-interceptor:4.5.0'
implementation 'com.squareup.moshi:moshi:1.8.0'

}
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,9 @@ public String getErrorMessage() {
return errorMessage;
}

public void setErrorMessage(String errorMessage) {
this.errorMessage = errorMessage;
}

public List<AROONIndicatorUnit> getIndicatorUnits() {
return indicatorUnits;
}

public void setIndicatorUnits(List<AROONIndicatorUnit> indicatorUnits) {
this.indicatorUnits = indicatorUnits;
}


public MetaData getMetaData() {
return metaData;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,9 @@ public String getErrorMessage() {
return errorMessage;
}

public void setErrorMessage(String errorMessage) {
this.errorMessage = errorMessage;
}

public List<MACDIndicatorUnit> getIndicatorUnits() {
return indicatorUnits;
}

public void setIndicatorUnits(List<MACDIndicatorUnit> indicatorUnits) {
this.indicatorUnits = indicatorUnits;
}


public MetaData getMetaData() {
return metaData;
Expand Down Expand Up @@ -190,23 +181,14 @@ public double getSignalPeriod() {
return signalPeriod;
}

/**
* @return the fastMaType
*/
public double getFastMaType() {
return fastMaType;
}

/**
* @return the slowMaType
*/
public double getSlowMaType() {
return slowMaType;
}

/**
* @return the signalMaType
*/
public double getSignalMaType() {
return signalMaType;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,9 @@ public String getErrorMessage() {
return errorMessage;
}

public void setErrorMessage(String errorMessage) {
this.errorMessage = errorMessage;
}

public List<MACDIndicatorUnit> getIndicatorUnits() {
return indicatorUnits;
}

public void setIndicatorUnits(List<MACDIndicatorUnit> indicatorUnits) {
this.indicatorUnits = indicatorUnits;
}


public MetaData getMetaData() {
return metaData;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,9 @@ public String getErrorMessage() {
return errorMessage;
}

public void setErrorMessage(String errorMessage) {
this.errorMessage = errorMessage;
}

public List<MAMAIndicatorUnit> getIndicatorUnits() {
return indicatorUnits;
}

public void setIndicatorUnits(List<MAMAIndicatorUnit> indicatorUnits) {
this.indicatorUnits = indicatorUnits;
}


public MetaData getMetaData() {
return metaData;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,10 @@ public String getErrorMessage() {
return errorMessage;
}

public void setErrorMessage(String errorMessage) {
this.errorMessage = errorMessage;
}

public List<SimpleIndicatorUnit> getIndicatorUnits() {
return indicatorUnits;
}

public void setIndicatorUnits(List<SimpleIndicatorUnit> indicatorUnits) {
this.indicatorUnits = indicatorUnits;
}


public MetaData getMetaData() {
return metaData;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,9 @@ public String getErrorMessage() {
return errorMessage;
}

public void setErrorMessage(String errorMessage) {
this.errorMessage = errorMessage;
}

public List<SimpleIndicatorUnit> getIndicatorUnits() {
return indicatorUnits;
}

public void setInidcatorUnits(List<SimpleIndicatorUnit> indicatorUnits) {
this.indicatorUnits = indicatorUnits;
}

public MetaData getMetaData() {
return metaData;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,9 @@ public String getErrorMessage() {
return errorMessage;
}

public void setErrorMessage(String errorMessage) {
this.errorMessage = errorMessage;
}

public List<SimpleIndicatorUnit> getIndicatorUnits() {
return indicatorUnits;
}

public void setIndicatorUnits(List<SimpleIndicatorUnit> indicatorUnits) {
this.indicatorUnits = indicatorUnits;
}


public MetaData getMetaData() {
return metaData;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,9 @@ public String getErrorMessage() {
return errorMessage;
}

public void setErrorMessage(String errorMessage) {
this.errorMessage = errorMessage;
}

public List<STOCHFIndicatorUnit> getIndicatorUnits() {
return indicatorUnits;
}

public void setIndicatorUnits(List<STOCHFIndicatorUnit> indicatorUnits) {
this.indicatorUnits = indicatorUnits;
}


public MetaData getMetaData() {
return metaData;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,10 @@ public String getErrorMessage() {
return errorMessage;
}

public void setErrorMessage(String errorMessage) {
this.errorMessage = errorMessage;
}

public List<STOCHRSIIndicatorUnit> getIndicatorUnits() {
return indicatorUnits;
}

public void setIndicatorUnits(List<STOCHRSIIndicatorUnit> indicatorUnits) {
this.indicatorUnits = indicatorUnits;
}

public MetaData getMetaData() {
return metaData;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,10 @@ public String getErrorMessage() {
return errorMessage;
}

public void setErrorMessage(String errorMessage) {
this.errorMessage = errorMessage;
}

public List<STOCHIndicatorUnit> getIndicatorUnits() {
return indicatorUnits;
}

public void setIndicatorUnits(List<STOCHIndicatorUnit> indicatorUnits) {
this.indicatorUnits = indicatorUnits;
}



public MetaData getMetaData() {
return metaData;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,9 @@ public String getErrorMessage() {
return errorMessage;
}

public void setErrorMessage(String errorMessage) {
this.errorMessage = errorMessage;
}

public List<SimpleIndicatorUnit> getIndicatorUnits() {
return indicatorUnits;
}

public void setIndicatorUnits(List<SimpleIndicatorUnit> indicatorUnits) {
this.indicatorUnits = indicatorUnits;
}


public MetaData getMetaData() {
return metaData;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,9 @@ public String getErrorMessage() {
return errorMessage;
}

public void setErrorMessage(String errorMessage) {
this.errorMessage = errorMessage;
}

public List<SimpleIndicatorUnit> getIndicatorUnits() {
return indicatorUnits;
}

public void setIndicatorUnits(List<SimpleIndicatorUnit> indicatorUnits) {
this.indicatorUnits = indicatorUnits;
}


public MetaData getMetaData() {
return metaData;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,9 @@ public String getErrorMessage() {
return errorMessage;
}

public void setErrorMessage(String errorMessage) {
this.errorMessage = errorMessage;
}

public List<SimpleIndicatorUnit> getIndicatorUnits() {
return indicatorUnits;
}

public void setIndicatorUnits(List<SimpleIndicatorUnit> indicatorUnits) {
this.indicatorUnits = indicatorUnits;
}


public MetaData getMetaData() {
return metaData;
Expand Down
Loading

0 comments on commit 71589ea

Please sign in to comment.