Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Fullscreen Mode for Modal Component #7

Closed
lucasferreiralimax opened this issue Oct 15, 2024 · 0 comments · Fixed by #8
Closed

Implement Fullscreen Mode for Modal Component #7

lucasferreiralimax opened this issue Oct 15, 2024 · 0 comments · Fixed by #8
Assignees
Labels
enhancement New feature or request hacktoberfest

Comments

@lucasferreiralimax
Copy link
Member

lucasferreiralimax commented Oct 15, 2024

We have implemented a new fullscreen mode for the modal component (UpWindowAngularComponent). The modal should now be able to expand to fill the entire screen instead of opening in the center.

Current Behavior

Currently, the modal opens in the center of the screen with a defined size.

Expected Behavior

When the fullscreen mode is activated:

  • The modal should expand to cover the entire viewport.
  • The content inside the modal should be properly adjusted to fit the fullscreen view.

Implementation Details

  • A new @Input() fullScreen property is introduced to manage the fullscreen state.

Steps to Reproduce

  1. Open the modal.
  2. Trigger the fullscreen mode.
  3. Observe that the modal expands to fill the screen.

Screenshot 2024-10-14 234738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant