Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Fullscreen Mode for UpWindowAngularComponent #8

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

lucasferreiralimax
Copy link
Member

This pull request implements a new fullscreen mode for the UpWindowAngularComponent. The modal can now expand to fill the entire screen instead of opening in the center, enhancing the user experience for viewing content that requires more screen space.

Changes Made

  • Introduced a new @Input() property called fullScreen to manage the fullscreen state.
  • Modified the component's template and styles to allow the modal to expand and fill the entire viewport when fullScreen is true.
  • Adjusted the content layout within the modal to fit the fullscreen view appropriately.
  • Updated unit tests to verify the fullscreen behavior.

Current Behavior

Currently, the modal opens in the center of the screen with a defined size.

Expected Behavior

When the fullscreen mode is activated:

  • The modal should expand to cover the entire viewport.
  • The content inside the modal should be properly adjusted to fit the fullscreen view.

Steps to Reproduce

  1. Open the modal by triggering the appropriate action.
  2. Activate the fullscreen mode by setting the fullScreen property to true.
  3. Observe that the modal expands to fill the screen.

Screenshots

Screenshot 2024-10-14 234738

@lucasferreiralimax lucasferreiralimax self-assigned this Oct 15, 2024
@lucasferreiralimax lucasferreiralimax linked an issue Oct 15, 2024 that may be closed by this pull request
@lucasferreiralimax lucasferreiralimax merged commit 5a48230 into master Oct 15, 2024
1 check passed
@lucasferreiralimax lucasferreiralimax deleted the fulllscreen branch October 15, 2024 03:13
Copy link

Visit the preview URL for this PR (updated for commit abc8387):

https://up-window-angular--pr8-fulllscreen-4gcvpj3i.web.app

(expires Tue, 22 Oct 2024 03:14:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7822e0d6e40bbbcb5ceaa0eda2c38488d7b613f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Fullscreen Mode for Modal Component
1 participant