Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Modal to Use up-window-container #21

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

lucasferreiralimax
Copy link
Member

This PR refactors the modal structure by introducing a new up-window-container component. The overlay-related logic and class bindings are moved outside the modal content to improve separation of concerns.

Changes:

  • Wrapped the modal inside a new up-window-container.
  • Moved overlay class bindings (blur, grayscale, active, etc.) to up-window-container.
  • Kept modal content (up-window) intact but cleaned up class and event handling.

Benefits:

  • Improved code organization and readability.
  • Clear distinction between overlay and modal content.
  • Easier to manage animations and visual effects in the future.

Testing:

  • Verified that the modal opens, closes, and behaves as expected.
  • Confirmed the proper application of animations and visual effects.

@lucasferreiralimax lucasferreiralimax self-assigned this Oct 17, 2024
@lucasferreiralimax lucasferreiralimax linked an issue Oct 17, 2024 that may be closed by this pull request
Copy link

Visit the preview URL for this PR (updated for commit f70d08f):

https://up-window-angular--pr21-refactory-overlay-r0gwbfsv.web.app

(expires Thu, 24 Oct 2024 18:15:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7822e0d6e40bbbcb5ceaa0eda2c38488d7b613f8

@lucasferreiralimax lucasferreiralimax merged commit 7ee1b0b into master Oct 17, 2024
2 checks passed
@lucasferreiralimax lucasferreiralimax deleted the refactory-overlay branch October 17, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Window Structure to Use up-window-container
1 participant