Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Custom Footer for up-window-angular Component #24

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

lucasferreiralimax
Copy link
Member

This pull request introduces a customizable footer for the up-window-angular component. It allows users to define custom action buttons in the modal's footer while removing the default buttons when the custom content is provided.

Testing:

  • Added unit tests to verify that the custom footer is rendered correctly when provided, and that default buttons are not displayed in that case.

@lucasferreiralimax lucasferreiralimax self-assigned this Oct 17, 2024
@lucasferreiralimax lucasferreiralimax linked an issue Oct 17, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 17, 2024

Visit the preview URL for this PR (updated for commit 1b6d2f7):

https://up-window-angular--pr24-custom-footer-90trhmth.web.app

(expires Thu, 24 Oct 2024 20:14:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7822e0d6e40bbbcb5ceaa0eda2c38488d7b613f8

@lucasferreiralimax lucasferreiralimax merged commit c5ea21b into master Oct 17, 2024
1 check passed
@lucasferreiralimax lucasferreiralimax deleted the custom-footer branch October 17, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Custom Footer for up-window-angular Component
1 participant