Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance GitHub Actions Workflow with Unit and Module Test Steps #25

Merged
merged 7 commits into from
Oct 17, 2024

Conversation

lucasferreiralimax
Copy link
Member

@lucasferreiralimax lucasferreiralimax commented Oct 17, 2024

This pull request updates the GitHub Actions workflow for deploying to Firebase Hosting. The following changes have been made:

  • Added Unit and Module Test Steps: Introduced steps to run unit tests and module tests before deploying to Firebase. This ensures that all tests pass successfully before any deployment occurs.
  • Improved Step Descriptions: Each step now has a clear and descriptive name, enhancing the readability and maintainability of the workflow.
  • Karma Configuration Updated: Adjusted the Karma configuration to support ChromeHeadlessCI for running tests in the CI environment.

Changes Made

  • Updated the .github/workflows/firebase-hosting-merge.yml and .github/workflows/firebase-hosting-pull-request.yml with the following changes:
    • Added steps to run unit tests and module tests.
    • Added descriptive names to each step for clarity.
  • Updated the karma.conf.js to support running tests in a headless Chrome environment for CI by adding the ChromeHeadlessCI configuration.

Checklist

  • Unit tests are passing
  • Module tests are passing
  • Karma configuration updated for CI

@lucasferreiralimax lucasferreiralimax added the enhancement New feature or request label Oct 17, 2024
@lucasferreiralimax lucasferreiralimax self-assigned this Oct 17, 2024
Copy link

Visit the preview URL for this PR (updated for commit 69cde4a):

https://up-window-angular--pr25-github-actions-rjh0uace.web.app

(expires Thu, 24 Oct 2024 21:36:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7822e0d6e40bbbcb5ceaa0eda2c38488d7b613f8

@lucasferreiralimax lucasferreiralimax merged commit f15bccb into master Oct 17, 2024
2 checks passed
@lucasferreiralimax lucasferreiralimax deleted the github-actions branch October 17, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant