Fix potential leak of endpoint clients during the initialisation of the probe #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the probe failed preparation, the driver would not be closed and be leaked forever. Also added more checks in the close to support closing even if it has not been connected yet.
Add tests to ensure endpoints are properly closed in case of failures.
Before we had 2 different paths depending on the check now we use only one. Also added unittest to have coverage on these functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was possible to not close an endpoint when a probe failed to start. If it failed during connect or during the execution of prepareFn, it was not closed.
Also added a lot of unit testing on the scheduler