Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable total timeout parameter #45

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

jfwm2
Copy link
Contributor

@jfwm2 jfwm2 commented Jan 24, 2025

  • Since we bumped from v5 to v7 of the Aerospike client the default timeout went from 0 (no timeout) to 1 second.
  • This change adds a configuration option to specify this value (total_timeout, e.g. "30s" in the yaml config). The default value is 30s
  • We also use explicitly (for readability) 2 retries for the durability checks (read and write policies): this is the default for read (aka. base) policy, while the default for write policiy is 0

  - Since we bumped from v5 to v7 of the Aerospike
    client the default timeout went from 0 (no timeout)
    to 1 second.
  - This change adds a configuration option to specify
    this value (total_timeout, e.g. "30s" in the yaml
    config). The default value is 30s
  - We also use explicitly (for readability) 2 retries
    for the durability checks (read and write policies):
    this is the default for read (aka. base) policy,
    while the default for write policiy is 0
@jfwm2 jfwm2 requested a review from geobeau January 24, 2025 16:57
@jfwm2 jfwm2 merged commit 087e9df into criteo:main Jan 27, 2025
1 check passed
@jfwm2 jfwm2 deleted the add-total-timeout branch January 27, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants