This repository has been archived by the owner on Oct 3, 2024. It is now read-only.
fix(github-workflows): update build and test workflows for Crosswind #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of Node.js such as 14.x, 16.x, and 18.x break the build, so we need to remove them from the build matrix. In the future, we should update the build to work with newer versions of Node.js.
Dangeranger
force-pushed
the
fix/update-the-github-actions-workflow-for-crosswind
branch
from
ee2a233 to
7358c43
Compare
Changes to package.json reflect updates to the: - Package version - Forked package homepage - Compatible Node.js engine versions - Package contributors
The package version will be updated automatically by the CI/CD pipeline when the build and tests succeed and a new release is created.
This commit adds the asset paths for the release workflow to NPM and Github. This will allow for the download of assets from the Github release page in addtion to installing via NPM.
This registry is the default registry for npm, but it can be overridden in the repositry settings. This commit sets the registry to the default.
This commit removes the need for yarn and uses npm instead. This reduces the number of tools needed to build the project and makes it easier to contribute to the project. Yarn appeared to be used for convenience.
Some packages have been updated to a slightly newer minor version, and the package-lock.json file has been updated to reflect this. The SHA512 signatures have been added to the package-lock.json file for all packages that have them available. SHA512 are a more secure hash than SHA1, and are now the default for npm.
When running the build workflow, we should use the CI mode to avoid interactions with the user. This is especially important when running the `npm install` command, which will fail if the user is not logged in to the npm registry.
The publish workflow needs to be able to publish a Github release and comment on issues and pull requests. It also needs to be able to use OIDC tokens for future npm provenance verificiation. This commit updates the workflow to request the necessary permissions. Additional changes have been made to the workflow to ensure that the correct Node.js version is used, that the npm cache is used, and that the CI environment variable is set. The latter is necessary to ensure that the `semantic-release` command is run in CI mode.
The terser-webpack-plugin is the successor to the uglifyjs-webpack-plugin and is the recommended plugin for minifying JavaScript. It is more actively maintained and has better support for ES6+ syntax. Update the babel-loader to be more specific about the version of browsers that we support. This will allow the terser-webpack-plugin to better optimize the output. BREAKING CHANGE: The uglifyjs-webpack-plugin is no longer used. The terser-webpack-plugin is now used instead.
Webpack is now configured to only build the main bundle and to show progress of the build as it is happening. The prior configuration would also build the demostic bundle, which is not needed for the main package.
This commit updates the webpack configuration to omit dead browser targets from the build. This should reduce the size of the bundle significantly, improve the performance of the application, and ease the maintenance burden of the project.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Github Actions workflows with the following changes.