Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft of a validation testing framework (Tests 6.1.1-6.1.7) #67

Merged
merged 7 commits into from
Oct 30, 2024

Conversation

oxisto
Copy link
Contributor

@oxisto oxisto commented Oct 15, 2024

This is work in progress, but it tries to provide an API for the implementation of 6.1 mandatory tests for validation.

It also adds a couple of 6.1.x tests as an example

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...tlin/io/github/csaf/sbom/validation/Requirement.kt 100.00% <100.00%> (ø)
...io/github/csaf/sbom/validation/ValidationResult.kt 100.00% <100.00%> (ø)
.../csaf/sbom/validation/requirements/Requirements.kt 85.41% <100.00%> (+0.31%) ⬆️
...io/github/csaf/sbom/validation/tests/Extensions.kt 100.00% <100.00%> (ø)
...tlin/io/github/csaf/sbom/validation/tests/Tests.kt 100.00% <100.00%> (ø)

@oxisto oxisto force-pushed the test-api branch 2 times, most recently from 889d59e to 887cf05 Compare October 21, 2024 20:01
@oxisto oxisto marked this pull request as ready for review October 21, 2024 20:05
@oxisto oxisto force-pushed the test-api branch 2 times, most recently from 3b8e1a5 to 159d488 Compare October 26, 2024 12:28
@oxisto oxisto added the module:validation Issues for the validation module label Oct 26, 2024
@oxisto oxisto changed the title Initial draft of a validation testing framework Initial draft of a validation testing framework (Tests 6.1.1-6.1.7) Oct 26, 2024
Copy link
Contributor

@KuechA KuechA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's sometimes not really straightforward to relate the paths mentioned in the spec to the code but it should match in most cases. Also, some descriptions would help sometimes.

oxisto and others added 2 commits October 29, 2024 00:20
This is work in progress, but it tries to provide an API for the implementation of 6.1 mandatory tests for validation.
lawid
lawid previously requested changes Oct 29, 2024
Copy link

@lawid lawid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stumbled on the term "Branche", any chance we can refer to the singular of "Csaf.Branche" as "Branch" instead?

WITHDRAWN: I'm having trouble with the submodules (yes i ran init and update), shouldn't there be a .gitmodules file?

@oxisto oxisto requested a review from KuechA October 29, 2024 22:33
@oxisto oxisto merged commit 7282313 into main Oct 30, 2024
6 checks passed
@oxisto oxisto deleted the test-api branch October 30, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:validation Issues for the validation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants