Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sophie/popup #220

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Sophie/popup #220

wants to merge 7 commits into from

Conversation

smeng3408
Copy link
Contributor

Overview

I added an announcements framework, so in the future, we can just load whatever image we want to have into the PopUp screen. The current popup code is commented out as there are no outgoing announcements.

Changes Made

  • created popup screen and UI design
  • added the recruitment popup resource
  • added code to HomeScreen and HomeViewModel to enable the popup
  • please do not remove unused imports, as they will be necessary if the popup is uncommented

Test Coverage

I manually tested it.

Screenshots (delete if not applicable)

Screenshot 2023-09-06 at 5 43 08 PM Popup icon in bottom right when not showing Screenshot 2023-09-06 at 5 43 21 PM Popup when expanded

@smeng3408 smeng3408 requested a review from emilyhu8 September 6, 2023 21:44
Copy link
Contributor

@emilyhu8 emilyhu8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants