Tweak peer dependencies #5020
Merged
Tweak peer dependencies #5020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ae37a7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dougmacknz
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As part of https://cultureamp.atlassian.net/browse/FEF-1571 I am trying to clean up some of the dependencies in next-template, including resolving some peerDependency warnings.
One of those required
@cultureamp/package-bundlerto supportpostcss-preset-envv10 as well as v9.The release notes are here: https://github.com/csstools/postcss-plugins/wiki/PostCSS-Preset-Env-10
TLDR the breaking changes are:
So v10 is a perfectly fine version to allow with the bundler.
What
react-textfitand@reach/*about react versions (clearly the thing we need them for works with React 18, even though the packages say they need older versions). This change has no effect on consuming repos, but it getskaizen-design-systemback to a state of having no peer-dependency warnings