Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade eslint to v9 #5338

Conversation

HeartSquared
Copy link
Contributor

@HeartSquared HeartSquared commented Dec 2, 2024

Why

Eslint 8 is deprecated. Keeping on top of dep updates.

What

  • Upgrade to eslint 9
  • Revised linting rules to be mostly based on current recommended rules
  • Removed eslint-plugin-ssr-friendly as it is not compatible with Eslint flat config (the only option in v9+)
  • Removed @stylistic/eslint-plugin as it conflicts too much with prettier
    • It does actually give us better control and nicer looking code, but we can revisit later if we are happy to remove prettier

Notes

You may need to update your VSCode to use the flat config
image

Related branches

  1. Release branch: release: upgrade eslint v9 #5339
  2. Config: This branch
  3. Auto fixes: style: eslint and prettier autofix #5340
  4. Manual fixes: style: manually fix linting errors #5341

Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: 6b2b055

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@HeartSquared HeartSquared force-pushed the heartsquared/upgrade-eslint-v9--config branch from 6054cf1 to 6b2b055 Compare December 4, 2024 05:57
@HeartSquared HeartSquared marked this pull request as ready for review December 4, 2024 06:11
@HeartSquared HeartSquared requested a review from a team as a code owner December 4, 2024 06:11
Copy link
Contributor

@mcwinter07 mcwinter07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scanned through the config and that looks good to me. We'll likely have lots of changes in code but this is to be expected 👍

@HeartSquared HeartSquared merged commit b32ccb1 into heartsquared/upgrade-eslint-v9--release Dec 4, 2024
16 of 18 checks passed
@HeartSquared HeartSquared deleted the heartsquared/upgrade-eslint-v9--config branch December 4, 2024 06:12
Copy link
Contributor

github-actions bot commented Dec 4, 2024

✨ Here is your branch preview! ✨

Last updated for commit 6b2b055: chore(eslint): allow console in codemods

HeartSquared added a commit that referenced this pull request Dec 5, 2024
* chore(deps): upgrade eslint to v9 (#5338)

* chore: update eslint and prettier config

* ci: updating eslint commands

* chore(eslint): allow console in codemods

* style: eslint and prettier autofix (#5340)

* style: manually fix linting errors (#5341)

* chore(bundler): delete unused util

* style: manually fix easy linting errors

* test: fix snapshot tests

* style: autofix less files

* fix: add or ignore linting for missing hook deps

* fix(TitleBlockZen): fix typescript error

* refactor(GenericTile): remove document checking useEffect

* refactor(ToggleSwitchField): rename variable
Zystix pushed a commit that referenced this pull request Dec 6, 2024
* chore(deps): upgrade eslint to v9 (#5338)

* chore: update eslint and prettier config

* ci: updating eslint commands

* chore(eslint): allow console in codemods

* style: eslint and prettier autofix (#5340)

* style: manually fix linting errors (#5341)

* chore(bundler): delete unused util

* style: manually fix easy linting errors

* test: fix snapshot tests

* style: autofix less files

* fix: add or ignore linting for missing hook deps

* fix(TitleBlockZen): fix typescript error

* refactor(GenericTile): remove document checking useEffect

* refactor(ToggleSwitchField): rename variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants