Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Workflow Style in RTL #5370

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Conversation

Zystix
Copy link
Contributor

@Zystix Zystix commented Dec 10, 2024

Why

The stepDivider styling for the Workflow componenent was misbehaving in RTL

https://cultureamp.atlassian.net/browse/KZN-2884

What

Reinstated RTL specific styling with the :dir(rtl) selector instead.

Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: 2251901

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Zystix Zystix marked this pull request as ready for review December 10, 2024 04:05
@Zystix Zystix requested a review from a team as a code owner December 10, 2024 04:05
@Zystix Zystix enabled auto-merge (squash) December 10, 2024 04:06
Copy link
Contributor

github-actions bot commented Dec 10, 2024

✨ Here is your branch preview! ✨

Last updated for commit 2251901: Add RTL stickersheet

Copy link
Contributor

@HeartSquared HeartSquared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Could you please add a Chromatic test so we ensure we don't miss this in the future? :)

@Zystix Zystix disabled auto-merge December 11, 2024 03:17
Copy link
Contributor

@HeartSquared HeartSquared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@Zystix Zystix merged commit e39ab1d into main Dec 11, 2024
18 of 19 checks passed
@Zystix Zystix deleted the KZN-2884/workflow-rtl-style-broken branch December 11, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants