Chore/replace deprecated devcontainer image #431
Conversation
use mount instead of relying on PYTHONPATH to find integration
| @@ -0,0 +1,4 @@ | |||
| colorlog==6.8.2 | |||
| homeassistant==2024.6.4 | |||
There was a problem hiding this comment.
Why is this hass pinned here?
There was a problem hiding this comment.
In the new devcontainer setup, HASS dependency is pinned here in requirements. These dependencies are for development only and are installed by the setup script. In the previous devcontainer setup I believe HASS was installed by default in the container image. The previous image also contained a script for selecting HASS version.
The pin 2024.6 is from integration_blueprint and somewhat arbitrary I guess.
There was a problem hiding this comment.
Please drop numpy and unpin homeassistant. We want the latest regular version
| ## This let's us have the structure we want <root>/custom_components/integration_blueprint | ||
| ## while at the same time have Home Assistant configuration inside <root>/config | ||
| ## without resulting to symlinks. | ||
| export PYTHONPATH="${PYTHONPATH}:${PWD}/custom_components" |
There was a problem hiding this comment.
No longer needed since custom_components is mounted in devcontainer.json.
Pythonpath won’t work anymore (unless you remove dependency on nordpool package) due to name collision with integration package.
There was a problem hiding this comment.
I have already removed the nordpool dependency. Please add it back so the scripts still works without dev container.
Upgrade devcontainer base image
Get devcontainer configuration up to date to make it easier to contribute.
BREAKING CHANGE:
devscript will not work outside devcontainer.fixes #365