correctly process export to yolo formats if both Train and default dataset are present #8884

Eldies · 2024-12-27T12:43:38Z

Motivation and context

depends on cvat-ai/datumaro#71

How has this been tested?

Checklist

I submit my changes into the develop branch
I have created a changelog fragment
I have updated the documentation accordingly
I have added tests to cover my changes
I have linked related issues (see GitHub docs)
I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

Dependency Updates
- Updated datumaro package to a new commit
- Upgraded orjson from version 3.10.12 to 3.10.13
- Upgraded ruamel-yaml from version 0.18.6 to 0.18.7

coderabbitai · 2024-12-27T12:43:45Z

Walkthrough

This pull request focuses on updating dependencies in the CVAT project's requirements files. The changes involve updating the datumaro package to a new commit hash, and incrementing versions of orjson and ruamel-yaml packages. These updates likely include bug fixes, minor improvements, or compatibility enhancements for the project's dependencies.

Changes

File	Changes
`cvat/requirements/base.in`	Updated `datumaro` package to a new Git commit hash
`cvat/requirements/base.txt`	- Updated `datumaro` package commit hash - Upgraded `orjson` from 3.10.12 to 3.10.13 - Upgraded `ruamel-yaml` from 0.18.6 to 0.18.7

Poem

🥕 Dependency dance, a rabbit's delight,
Packages hop to a version so bright
Datumaro leaps, orjson takes flight
YAML twirls with renewed might
Coding magic in the moonlight! 🐰✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 279db7c and 1bcf297.

📒 Files selected for processing (2)

cvat/requirements/base.in (1 hunks)
cvat/requirements/base.txt (4 hunks)

🔇 Additional comments (5)

cvat/requirements/base.in (1)

15-15: Confirm new commit reference for datumaro
Please ensure that the specified commit hash (02507a9d41413327ca2d67a4349e5553ce763a7c) corresponds to the changes you need from the linked Datumaro PR (datumaro/pull/71).

✅ Verification successful

Commit hash corresponds to the referenced PR changes

The commit hash 02507a9d41413327ca2d67a4349e5553ce763a7c in the requirements file directly corresponds to the merge of PR #71 in the Datumaro repository. The commit message and changes confirm this:

PR Cuda installation has been fixed #71: "yolo: if train subset already present, merge default subset into it"
Changes affect YOLO format handling in converter.py and related test files
Recent commit from December 31, 2024

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Retrieve the commit details from the Datumaro repository
# to confirm it aligns with the required PR changes.
rm -rf /tmp/datumaro-check
git clone https://github.com/cvat-ai/datumaro.git /tmp/datumaro-check
pushd /tmp/datumaro-check
git show 02507a9d41413327ca2d67a4349e5553ce763a7c --stat
popd

Length of output: 944

cvat/requirements/base.txt (4)

1-1: No concerns regarding the updated SHA1
This line is autogenerated, so no manual modifications appear necessary.

59-59: Verify the Datumaro commit hash
Double-check that this commit (02507a9d41413327ca2d67a4349e5553ce763a7c) references the correct changes for exporting to YOLO formats.

200-200: Check orjson update for any compatibility issues
You’ve updated orjson from 3.10.12 to 3.10.13. Ensure there are no breaking changes that might affect data serialization or performance.

311-311: Check ruamel-yaml update for any regressions
ruamel-yaml has been updated from 0.18.6 to 0.18.7. Please verify that parsing and serialization behaviors remain consistent.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov-commenter · 2024-12-27T13:59:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.90%. Comparing base (279db7c) to head (1bcf297).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #8884      +/-   ##
===========================================
- Coverage    73.91%   73.90%   -0.02%     
===========================================
  Files          411      411              
  Lines        44174    44174              
  Branches      3993     3993              
===========================================
- Hits         32653    32647       -6     
- Misses       11521    11527       +6

Components	Coverage Δ
cvat-ui	`78.36% <ø> (-0.03%)`	⬇️
cvat-server	`70.10% <ø> (ø)`

Marishka17 · 2024-12-30T12:47:58Z

cvat/requirements/base.txt

@@ -56,7 +56,7 @@ cryptography==44.0.0
    #   pyjwt
 cycler==0.12.1
    # via matplotlib
-datumaro @ git+https://github.com/cvat-ai/datumaro.git@232c175ef1f3b7e55bd5162353df9c86a8116fde
+datumaro @ git+https://github.com/cvat-ai/datumaro.git@8c9cfa64770694ee93ca23d367094e862d24fa86


Did you update the commit manually? I don't see the SHA1 to be changed

Yes. These lines will need to be changed anyway, after merge of related Datumaro PR

updated it with pip-compile-multi

sonarqubecloud · 2024-12-31T12:30:36Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Eldies requested a review from Marishka17 as a code owner December 27, 2024 12:43

update datumaro

362e473

Eldies force-pushed the dl/yolo-subsets branch from 6908e6a to 362e473 Compare December 27, 2024 12:46

Marishka17 reviewed Dec 30, 2024

View reviewed changes

Eldies added 2 commits December 31, 2024 16:09

Merge branch 'refs/heads/develop' into dl/yolo-subsets

0ebcd90

update datumaro

1bcf297

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

correctly process export to yolo formats if both Train and default dataset are present #8884

correctly process export to yolo formats if both Train and default dataset are present #8884

Eldies commented Dec 27, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 27, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

codecov-commenter commented Dec 27, 2024 •

edited

Loading

Marishka17 Dec 30, 2024

Eldies Dec 30, 2024 •

edited

Loading

Eldies Dec 31, 2024

sonarqubecloud bot commented Dec 31, 2024

correctly process export to yolo formats if both Train and default dataset are present #8884

Are you sure you want to change the base?

correctly process export to yolo formats if both Train and default dataset are present #8884

Conversation

Eldies commented Dec 27, 2024 • edited by coderabbitai bot Loading

Motivation and context

How has this been tested?

Checklist

License

Summary by CodeRabbit

coderabbitai bot commented Dec 27, 2024 • edited Loading

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

codecov-commenter commented Dec 27, 2024 • edited Loading

Codecov Report

Marishka17 Dec 30, 2024

Choose a reason for hiding this comment

Eldies Dec 30, 2024 • edited Loading

Choose a reason for hiding this comment

Eldies Dec 31, 2024

Choose a reason for hiding this comment

sonarqubecloud bot commented Dec 31, 2024

Quality Gate passed

Eldies commented Dec 27, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 27, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov-commenter commented Dec 27, 2024 •

edited

Loading

Eldies Dec 30, 2024 •

edited

Loading