-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unstable headlessCreateUser cypress command #8885
base: develop
Are you sure you want to change the base?
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request introduces an enhancement to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/cypress/support/commands.js (1)
363-366
: Improved test stability with response validationThe added assertions ensure the user creation request succeeds and returns the expected data, making the test more reliable.
Consider also asserting other important user properties like
username
andfirst_name
to make the validation even more comprehensive:}).then((response) => { expect(response.status).to.eq(201); expect(response.body.email).to.eq(userSpec.email); + expect(response.body.username).to.eq(userSpec.username); + expect(response.body.first_name).to.eq(userSpec.firstName); return cy.wrap(); });
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8885 +/- ##
===========================================
+ Coverage 73.89% 73.93% +0.04%
===========================================
Files 408 408
Lines 44131 44131
Branches 3986 3986
===========================================
+ Hits 32611 32629 +18
+ Misses 11520 11502 -18
|
Motivation and context
How has this been tested?
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit