support conditional ignore of Modbus broadcast frames #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlp
added a commit
to etactica/freemodbus
that referenced
this pull request
Jun 9, 2022
If user provided address checking is enabled, the user function takes
complete responsibility for validating. An example function would be:
```
BOOL isMBUserAddressValid( UCHAR ucMBAddress, UCHAR ucRcvAddress )
{
if (
/* Accept our originally configured address */
(ucMBAddress == ucRcvAddress) ||
/* Accept all even, non-broadcast addresses less than 50 */
(ucRcvAddress > 0 && ucRcvAddress < 50 && ((ucRcvAddress & 0x1) == 0))
) {
return true;
}
return false;
}
```
This allows fixing issues such as: cwalter-at#27
in a more general fashion.
Note that this does not affect the STRICT_ADDRESSING or
QUIRK_REPLY_BROADCAST_READ options, which are _after_ we have decided to
look at the frame.
Signed-off-by: Karl Palsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this is a case where I have several identical slaves on the bus (fulfilling different, but similar roles), and sometimes it is desirable to instruct a slave to ignore the collective.