Replace regexes with pairvalues in atbash-cipher (exercism#323)

cxw42 · Sep 30, 2019 · 91627ac · 91627ac
1 parent 8528522
commit 91627ac
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/exercises/atbash-cipher/.meta/exercise-data.yaml b/exercises/atbash-cipher/.meta/exercise-data.yaml
@@ -13,11 +13,13 @@ tests: |-
   }
 
 example: |-
+  use List::Util qw(pairvalues);
+
   my %dict;
   @dict{'a'..'z'} = reverse('a'..'z');
 
   sub encode_atbash {
-    join( ' ', split( /(\w{5})/, decode_atbash(@_) ) ) =~ s/\s+/ /gr =~ s/^\s//r;
+    join( ' ', pairvalues split( /(\w{1,5})/, decode_atbash(@_) ) );
   }
 
   sub decode_atbash {

diff --git a/exercises/atbash-cipher/.meta/solutions/AtbashCipher.pm b/exercises/atbash-cipher/.meta/solutions/AtbashCipher.pm
@@ -4,12 +4,13 @@ use warnings;
 use Exporter 'import';
 our @EXPORT_OK = qw(encode_atbash decode_atbash);
 
+use List::Util qw(pairvalues);
+
 my %dict;
 @dict{ 'a' .. 'z' } = reverse( 'a' .. 'z' );
 
 sub encode_atbash {
-  join( ' ', split( /(\w{5})/, decode_atbash(@_) ) ) =~ s/\s+/ /gr
-    =~ s/^\s//r;
+  join( ' ', pairvalues split( /(\w{1,5})/, decode_atbash(@_) ) );
 }
 
 sub decode_atbash {