Expose support for multiple with on same relation
#483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gam6itko could you add test cases? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #483 +/- ##
=========================================
Coverage 91.52% 91.52%
Complexity 1817 1817
=========================================
Files 115 115
Lines 4613 4615 +2
=========================================
+ Hits 4222 4224 +2
Misses 391 391 ☔ View full report in Codecov by Sentry. |
roxblnfk
changed the title
with support via alias
roxblnfk
changed the title
with support via aliaswith on same relation
roxblnfk
changed the title
with on same relationwith on same relation
roxblnfk
force-pushed
the
feature/with-alias
branch
from
6e9a14a to
4714f5f
Compare
|
CI fail related with bug introduced in PHP 8.3.8 php/php-src#14480 Based on the previous successful CI run I'm merging the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
Added key
aliasforSelect::with()options.Note
There is PoC. Tests required
📝 Checklist
withmore than once with same relation. For several JOINs #482📃 Documentation