fix(backend): jmap config with smtp server #1425
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josaphatim
reviewed
Jan 26, 2025
modules/core/handler_modules.php
Outdated
| @@ -1079,6 +1079,18 @@ public function process() { | |||
| return; | |||
| } | |||
|
|
|||
| if($isSender){ | |||
There was a problem hiding this comment.
I think the best way is to put this block of code out of its parent if so we avoid duplication.
Shadow243
force-pushed
the
fixed-jmap-conf-with-sender-server
branch
from
ca1d0ae to
e63a076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored server connection logic to handle cases where JMAP and SMTP coexist.
Currently, JMAP is added alone when
$onlyJmapis true. The update replaces IMAP with JMAP in this case while allowing the possibility to check and add SMTP if$isSenderis true.