-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #488 that ShellFolder.EnumerateChildIds might throw NullReferenceException if failed to enum the objects #499
base: master
Are you sure you want to change the base?
Conversation
…eferenceException if failed to enum the objects
@zhuxb711 ...and have a happy new year! |
@tajbender Thanks, and happy new year to you too! |
@zhuxb711 do you have Build Issues? Warnings etc.? |
I did not build the repo on local because the change is simple enough and should not have any impact and build issue. There is no warning on my side. |
@tajbender I built it on my local and everything is fine. Thanks~ |
@dahall Hi David, would you please take a look at this PR. And please help merge it if have no concerns. Thanks~ |
@tajbender Are you the manager on this repo? Why @dahall did not response? |
Please read the FAQs. This is a hobbies' project, has been in development for about ten years now. Besides that, there are endless supporters in terms of bug fixes, testing, bug reporting etc. pp. It's just an Open Source project. Everyone is free to download the code and adopt his own fixes. If you can't wait some more days, well, then just use the class in your project as a temporary fix. That's what others do. Regards, |
@tajbender Sorry but I think you miss-understand my thoughts. I'm wondering whether David no longer support this repo and the maintainer had already changed to you. Just ask in case I missed anything importance haha😁 |
No prob 👍 Just look at the Commit History: https://github.com/dahall/Vanara/commits/master/ His last commit was just a few days ago, so be patient. My role is a supporting one: https://github.com/dahall/Vanara/graphs/contributors - so You are right, I've been working on Shell32 Stuff for some years now, about seven, I guess. There is a dummy fork for the WinUI3 stuff, mostly written by myself currently:
However, that's why I wrote I plan to have an alpha version of those the next weeks. This will be my first package that I release through NuGet, so just be patient. Have an enjoyable day, tajbender e./ btw, this is the current development branch of WinUI3 stuff: |
BTW: May you share a license of This would help testing those Shell32 on WinUI3 stuff a lot. Thanks in advance. |
@tajbender RX-Explorer (WAS) not RX-Player haha. License? You mean a redemption code which could activate RX-Explorer (WAS) on Microsoft Store and make it out of trial status right? It's easy, please contact me through my email. Thanks. |
Thanks a lot... Have a nice weekend! |
Here you can see my bug: |
Fixed #488