Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #488 that ShellFolder.EnumerateChildIds might throw NullReferenceException if failed to enum the objects #499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhuxb711
Copy link

@zhuxb711 zhuxb711 commented Jan 2, 2025

Fixed #488

…eferenceException if failed to enum the objects
@tajbender
Copy link
Contributor

tajbender commented Jan 2, 2025

@zhuxb711
I may test this in (classic) electrifier soon, if this may help.
But seeing the code, your commit looks good. Just gimme some time

...and have a happy new year!

@zhuxb711
Copy link
Author

zhuxb711 commented Jan 2, 2025

@tajbender Thanks, and happy new year to you too!

@tajbender
Copy link
Contributor

@zhuxb711 do you have Build Issues?

Warnings etc.?

@zhuxb711
Copy link
Author

zhuxb711 commented Jan 3, 2025

I did not build the repo on local because the change is simple enough and should not have any impact and build issue. There is no warning on my side.

@zhuxb711
Copy link
Author

zhuxb711 commented Jan 3, 2025

@tajbender I built it on my local and everything is fine. Thanks~

@zhuxb711
Copy link
Author

zhuxb711 commented Jan 3, 2025

@dahall Hi David, would you please take a look at this PR. And please help merge it if have no concerns. Thanks~

@tajbender
Copy link
Contributor

@dahall Hi David, would you please take a look at this PR. And please help merge it if have no concerns. Thanks~

@zhuxb711 I'll build a debug package for NuGet, just wait for the weekend...

I must debug my life first 💌

@zhuxb711
Copy link
Author

zhuxb711 commented Jan 3, 2025

@tajbender Are you the manager on this repo? Why @dahall did not response?

@tajbender
Copy link
Contributor

@tajbender Are you the manager on this repo? Why @dahall did not response?

Please read the FAQs.

This is a hobbies' project, has been in development for about ten years now.
@dahall is doing all these million lines of code just for fun in his spare time.

Besides that, there are endless supporters in terms of bug fixes, testing, bug reporting etc. pp.

It's just an Open Source project. Everyone is free to download the code and adopt his own fixes.

If you can't wait some more days, well, then just use the class in your project as a temporary fix. That's what others do.

Regards,
tajbender

@zhuxb711
Copy link
Author

zhuxb711 commented Jan 3, 2025

@tajbender Sorry but I think you miss-understand my thoughts. I'm wondering whether David no longer support this repo and the maintainer had already changed to you. Just ask in case I missed anything importance haha😁

@tajbender
Copy link
Contributor

tajbender commented Jan 3, 2025

No prob 👍

Just look at the Commit History: https://github.com/dahall/Vanara/commits/master/

His last commit was just a few days ago, so be patient.

My role is a supporting one: https://github.com/dahall/Vanara/graphs/contributors - so You are right, I've been working on Shell32 Stuff for some years now, about seven, I guess.

There is a dummy fork for the WinUI3 stuff, mostly written by myself currently:

However, that's why I wrote I plan to have an alpha version of those the next weeks. This will be my first package that I release through NuGet, so just be patient.

Have an enjoyable day,
thanks for support,

tajbender

e./ btw, this is the current development branch of WinUI3 stuff:

@tajbender
Copy link
Contributor

tajbender commented Jan 3, 2025

BTW: May you share a license of RX-Explorer (WAS) on the Microsoft Store?

This would help testing those Shell32 on WinUI3 stuff a lot.
I'll give you my e-mail then.

Thanks in advance.

@zhuxb711
Copy link
Author

zhuxb711 commented Jan 3, 2025

@tajbender RX-Explorer (WAS) not RX-Player haha. License? You mean a redemption code which could activate RX-Explorer (WAS) on Microsoft Store and make it out of trial status right?

It's easy, please contact me through my email. Thanks.

@tajbender
Copy link
Contributor

tajbender commented Jan 3, 2025

Thanks a lot...
e./ Yep, will be coming soon.

Have a nice weekend!

@tajbender
Copy link
Contributor

Here you can see my bug:

https://www.youtube.com/watch?v=ijMJe8dk9w4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EnumerateChildIds throws NullReferenceException if children not available
2 participants