feat: Update extension banner experiment #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
AmarTrebinjac
changed the title
AmarTrebinjac
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
sshanzel and
nensidosari
sshanzel
approved these changes
Dec 20, 2024
| @@ -10,6 +11,7 @@ interface ClassName { | |||
| } | |||
|
|
|||
| interface OnboardingHeadlineProps { | |||
| avatar?: ReactElement; | |||
There was a problem hiding this comment.
Suggested change
| avatar?: ReactElement; | |
| avatar?: ReactNode; |
| const { showLogin } = useAuthContext(); | ||
|
|
||
| return ( | ||
| <BottomBannerContainer | ||
| className={classNames( | ||
| 'gap-24 border-t border-accent-cabbage-default py-10 shadow-3 laptopL:gap-32', |
There was a problem hiding this comment.
Are these classes removed as intended?
There was a problem hiding this comment.
@sshanzel Yeah, design has 40px gap between the sections and Tsahi specifically mentioned the gap sized in the sync 😄
rebelchris
approved these changes
Dec 20, 2024
… title2 on social and user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update extension experiment banner with new changes. Unsure if this needs a logEvent. Asked Ido for clarification.
Changes from quick sync with Tsahi:
Added icon size 48 because this is the size from the design, but the icons in the banner were slightly bigger before.
examples:
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://mi-703.preview.app.daily.dev
MI-703 #done