Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: type import rules #4024

Merged
merged 12 commits into from
Dec 24, 2024
Merged

chore: type import rules #4024

merged 12 commits into from
Dec 24, 2024

Conversation

rebelchris
Copy link
Contributor

@rebelchris rebelchris commented Dec 24, 2024

Changes

Quite a big PR, but really only made sure types get imported correctly and enforce it in tsconfig and linter.

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://chore-type-import.preview.app.daily.dev

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Dec 24, 2024 11:43am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Dec 24, 2024 11:43am

Copy link
Member

@idoshamun idoshamun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't review really but if it's only import change we're good to go

@rebelchris rebelchris merged commit adac70d into main Dec 24, 2024
10 checks passed
@rebelchris rebelchris deleted the chore-type-import branch December 24, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants