Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup experiment upvote counter always visible #4030

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

sshanzel
Copy link
Member

@sshanzel sshanzel commented Jan 2, 2025

Changes

https://dailydotdev.slack.com/archives/C02JAUF8HJL/p1735716046928839

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://mi-710.preview.app.daily.dev

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Jan 2, 2025 9:56am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Jan 2, 2025 9:56am

@sshanzel sshanzel marked this pull request as ready for review January 2, 2025 09:56
@sshanzel sshanzel requested a review from a team as a code owner January 2, 2025 09:56
Copy link
Contributor

@rebelchris rebelchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need the other one?

@sshanzel
Copy link
Member Author

sshanzel commented Jan 2, 2025

We still need the other one?

Yes. Plan is, it should run at a different time from this one.

@sshanzel sshanzel merged commit 3fbbfb3 into main Jan 2, 2025
11 checks passed
@sshanzel sshanzel deleted the MI-710 branch January 2, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants