Do not swallow config.ignore regexp errors

danmayer · Oct 18, 2024 · e70fe5b · e70fe5b
1 parent b9d98e7
commit e70fe5b
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/lib/coverband/configuration.rb b/lib/coverband/configuration.rb
@@ -224,8 +224,6 @@ def search_paths=(path_array)
     def ignore=(ignored_array)
       ignored_array = ignored_array.map { |ignore_str| Regexp.new(ignore_str) }
       @ignore |= ignored_array
-    rescue RegexpError
-      logger.error "an invalid regular expression was passed in, ensure string are valid regex patterns #{ignored_array.join(",")}"
     end
 
     def current_root

diff --git a/test/coverband/configuration_test.rb b/test/coverband/configuration_test.rb
@@ -38,16 +38,6 @@ def setup
     assert_equal expected, Coverband.configuration.ignore
   end
 
-  test "ignore catches regex errors" do
-    Coverband.configuration.logger.expects(:error).with("an invalid regular expression was passed in, ensure string are valid regex patterns *invalidRegex*")
-    Coverband.configure do |config|
-      config.ignore = ["*invalidRegex*"]
-    end
-    Coverband::Collectors::Coverage.instance.reset_instance
-    expected = (Coverband::Configuration::IGNORE_DEFAULTS << "config/environments").map { |str| Regexp.new(str) }
-    assert_equal expected, Coverband.configuration.ignore
-  end
-
   test "ignore" do
     Coverband::Collectors::Coverage.instance.reset_instance
     assert !Coverband.configuration.ignore.first.nil?