-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis-CI: Try more recent compilers with docker #196
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
precise is now EOL, and so by default travis will route to trusty
2332378
to
a5c7143
Compare
This checks online if the local copy of debian:buster is still up to date.
Recent clang versions include this diagnostic. Until it is confirmed whether this is a false positive, a library misuse or an upstream bug, it should stay in as a warning.
e1e0f65
to
d8eb9af
Compare
Upstream brew formula for poppler does no longer build against qt4, it always uses qt5.
This includes gcc-7, gcc-8, clang-5.0 and clang-6.0
Both compilers support a warning about unnecessary parenthesis in code. Both get triggered by the auto-generated code from Qt's moc. Since the issue is not in the local code, it should not stop compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to reproduce #191 I created a local docker image with clang-5.0.
This PR includes that docker images definition and a small wrapper script to make travis build the image, and then try to compile dspdfviewer inside the docker container.