Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "_PACKAGE" to naflex.R file #1

Merged
merged 6 commits into from
Oct 13, 2024

Conversation

lilyclements
Copy link
Contributor

No description provided.

Copy link
Contributor Author

@lilyclements lilyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dannyparsons I've made the changes, let me know if you are happy with it.

Would you like me to update it on CRAN for you? (I assume I can do the source build my end, and put in your details as maintainer etc still)

@dannyparsons
Copy link
Owner

Thanks, that was quick! It looks like my checks are out of date, hence failing. Would you be able to see if you can update them? Maybe on a separate branch. They should just be the standard ones suggested for R packages for testing and package build checks.

Also, I think the NEWS needs to be updated and the version number? Or is that done at the same time as CRAN submission?

@dannyparsons
Copy link
Owner

Also, I suggest adding yourself to the authors list in DESCRIPTION, maybe with the role ctb? As suggested here for patch contribution https://r-pkgs.org/description.html#sec-description-authors-at-r

@lilyclements
Copy link
Contributor Author

lilyclements commented Oct 13, 2024

@dannyparsons have done all this now - updated checks and code cov files (it looks like it's worked my end - I can't see a fail coming up!), and updated the description and news files

EDIT: I see, I think you need to approve it before I can see if that's fixed the checks problem.

@dannyparsons
Copy link
Owner

Thanks, this looks great! All checks passing now.
If you're about to submit the update to CRAN that would be amazing thank you.

@dannyparsons dannyparsons merged commit 75809a0 into dannyparsons:master Oct 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants