Full .Net Runtime implementation #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking Changes: The WindowsDesktop runtime is now handled with CheckWindowsDesktop! The dotnet runtime is now correctly handled by CheckDotNetCore
… compatibility. In addition, update the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an improved version of #6 and fully implements all dot net runtimes. It also adds the ability to override the target platform in case a x86 version shall be installed on a x64 Windows. The old macros are kept and mapped to the new generic functions. However, they are marked as deprecated because the naming is misleading (DotNetCore macro installs WindowsDesktop runtime).