Parts. Remove GatherUsedImportedElementsVisitor.

Change-Id: Ice56db3284631bf7cd3fe6e9c519f577c3486303 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/384120 Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
dart-lang · Sep 7, 2024 · b775d29 · b775d29
1 parent 319bdf4
commit b775d29
Show file tree

Hide file tree

Showing 4 changed files with 79 additions and 500 deletions.
diff --git a/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart b/pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart
@@ -313,25 +313,18 @@ class LibraryAnalyzer {
     _libraryVerificationContext.constructorFieldsVerifier.report();
 
     if (_analysisOptions.warning) {
-      var usedImportedElements = <UsedImportedElements>[];
       var usedLocalElements = <UsedLocalElements>[];
       for (var fileAnalysis in _libraryFiles.values) {
         {
           var visitor = GatherUsedLocalElementsVisitor(_libraryElement);
           fileAnalysis.unit.accept(visitor);
           usedLocalElements.add(visitor.usedElements);
         }
-        {
-          var visitor = GatherUsedImportedElementsVisitor(_libraryElement);
-          fileAnalysis.unit.accept(visitor);
-          usedImportedElements.add(visitor.usedElements);
-        }
       }
       var usedElements = UsedLocalElements.merge(usedLocalElements);
       for (var fileAnalysis in _libraryFiles.values) {
         _computeWarnings(
           fileAnalysis,
-          usedImportedElements: usedImportedElements,
           usedElements: usedElements,
         );
       }
@@ -465,7 +458,6 @@ class LibraryAnalyzer {
 
   void _computeWarnings(
     FileAnalysis fileAnalysis, {
-    required List<UsedImportedElements> usedImportedElements,
     required UsedLocalElements usedElements,
   }) {
     var errorReporter = fileAnalysis.errorReporter;
@@ -509,14 +501,12 @@ class LibraryAnalyzer {
         fileAnalysis: fileAnalysis,
       );
       verifier.addImports(unit);
-      usedImportedElements.forEach(verifier.removeUsedElements);
       verifier.generateDuplicateExportWarnings(errorReporter);
       verifier.generateDuplicateImportWarnings(errorReporter);
       verifier.generateDuplicateShownHiddenNameWarnings(errorReporter);
       verifier.generateUnusedImportHints(errorReporter);
       verifier.generateUnusedShownNameHints(errorReporter);
-      verifier.generateUnnecessaryImportHints(
-          errorReporter, usedImportedElements);
+      verifier.generateUnnecessaryImportHints(errorReporter);
     }
 
     // Unused local elements.