Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docset path confusion with underscores #84

Open
tko opened this issue Jun 13, 2015 · 2 comments
Open

Docset path confusion with underscores #84

tko opened this issue Jun 13, 2015 · 2 comments

Comments

@tko
Copy link
Contributor

tko commented Jun 13, 2015

When you install docsets that have underscores in the name the end result is rather unpredictable, e.g.

  • Bootstrap_2 => Bootstrap.docset
  • Bootstrap_3 => Bootstrap 3.docset
  • Common_Lisp => Common Lisp.docset
  • Emacs_Lisp => Emacs Lisp.docset

In a way none of docsets are available after installation due to underscore / whitespace mismatch, not to mention the loss of '2' even. I'd think the docsets should be available with the exact same id that was used for installing.

On the other hand dash itself installs docsets little differently which keeps the id intact, though it is never really shown to the user, e.g.

  • Bootstrap_2 => Bootstrap_2/Bootstrap.docset
  • Bootstrap_3 => Bootstrap_3/Bootstrap 3.docset
  • Common_Lisp => Common_Lisp/Common Lisp.docset
  • Emacs_Lisp => Emacs_Lisp/Emacs Lisp.docset

In this scenario helm-dash is failing to notice already installed docsets because of the small differences between directory names.

@stardiviner
Copy link
Contributor

+1

tko added a commit to tko/helm-dash that referenced this issue Jun 14, 2015
The paths where dash itself installs the docsets is somewhat
unpredictable (dash-docs-el#84) and can not be reliably determined from the docset
name/id alone. For example:
* Bootstrap_2 => Bootstrap_2/Bootstrap.docset
* Bootstrap_3 => Bootstrap_3/Bootstrap 3.docset
* Emacs_Lisp => Emacs_Lisp/Emacs Lisp.docset

Try harder to find them simply by looking inside the directory and
accepting the first *.docset directory present. The list of paths
searched is now:
* {name/id}.docset             -- helm-dash installation, probably
* {name/id}/{name/id}.docset   -- dash installation, e.g. Haskell
* {name/id}/*.docset           -- dash installation, e.g. Bootstrap_2
@areina
Copy link
Member

areina commented Jul 20, 2015

We just merged #87 that should fix this. Could someone test it and confirm? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants