Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try harder to find dash installed docsets #87

Merged
merged 1 commit into from
Jul 20, 2015
Merged

Conversation

tko
Copy link
Contributor

@tko tko commented Jun 14, 2015

The paths where dash itself installs the docsets is somewhat
unpredictable (#84) and can not be reliably determined from the docset
name/id alone. For example:

  • Bootstrap_2 => Bootstrap_2/Bootstrap.docset
  • Bootstrap_3 => Bootstrap_3/Bootstrap 3.docset
  • Emacs_Lisp => Emacs_Lisp/Emacs Lisp.docset

Try harder to find them simply by looking inside the directory and
accepting the first *.docset directory present. The list of paths
searched is now:

  • {name/id}.docset -- helm-dash installation, probably
  • {name/id}/{name/id}.docset -- dash installation, e.g. Haskell
  • {name/id}/*.docset -- dash installation, e.g. Bootstrap_2

The paths where dash itself installs the docsets is somewhat
unpredictable (dash-docs-el#84) and can not be reliably determined from the docset
name/id alone. For example:
* Bootstrap_2 => Bootstrap_2/Bootstrap.docset
* Bootstrap_3 => Bootstrap_3/Bootstrap 3.docset
* Emacs_Lisp => Emacs_Lisp/Emacs Lisp.docset

Try harder to find them simply by looking inside the directory and
accepting the first *.docset directory present. The list of paths
searched is now:
* {name/id}.docset             -- helm-dash installation, probably
* {name/id}/{name/id}.docset   -- dash installation, e.g. Haskell
* {name/id}/*.docset           -- dash installation, e.g. Bootstrap_2
@areina
Copy link
Member

areina commented Jul 20, 2015

Merging, thank you @tko !!

areina added a commit that referenced this pull request Jul 20, 2015
Try harder to find dash installed docsets
@areina areina merged commit ebd34d2 into dash-docs-el:master Jul 20, 2015
@rswgnu
Copy link

rswgnu commented Apr 23, 2019

Downloaded the latest helm-dash today and having a problem like this with the Python_3 docset. All other docsets that I use appear in searches but nothing comes up for the Python_3 docset. I don't know yet if it is the underscore or the fact that many of its html and toc files are in subdirectories. Does helm-dash handle docsets with many subdirectories of HTML files?

@kidd
Copy link
Member

kidd commented Apr 23, 2019

My python3 docset looks like "Python 3" in the docsets list and works ok. Make sure helm-dash can find the docset in the path+name

@rswgnu
Copy link

rswgnu commented Apr 23, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants