Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Files API client: recover on download failures (#844) #845

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ksafonov-db
Copy link

What changes are proposed in this pull request?

  1. Extending Files API client to support resuming download on failures. New implementation tracks current offset in the input stream and issues a new download request from this point in case of an error.
  2. New code path is enabled by 'DATABRICKS_ENABLE_EXPERIMENTAL_FILES_API_CLIENT' config parameter.

How is this tested?

Added unit tests for the new code path:
% python3 -m pytest tests/test_files.py

@ksafonov-db ksafonov-db deployed to test-trigger-is December 31, 2024 00:06 — with GitHub Actions Active
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-py

Inputs:

  • PR number: 845
  • Commit SHA: 644ec168275c5f1bc72d38cd118f603c2442d092

Checks will be approved automatically on success.

@renaudhartert-db renaudhartert-db changed the title Files API client: recover on download failures (#844) [Feature] Files API client: recover on download failures (#844) Jan 2, 2025
@renaudhartert-db renaudhartert-db self-requested a review January 2, 2025 12:58
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12582804714

Copy link
Contributor

@renaudhartert-db renaudhartert-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants