Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exporter] Improve code generation for SQL Endpoints #3764

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[Exporter] Improve code generation for SQL Endpoints #3764

merged 1 commit into from
Jul 16, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jul 13, 2024

Changes

Changes include:

  • Always generate enable_serverless_compute attribute for databricks_sql_endpoint and databricks_sql_global_config - this is required when there is a mix of serverless & non-serverless SQL endpoints
  • Don't generate channel when it's empty or is current
  • Don't generate tags block when there are no tags
  • Importable can define ShouldGenerateField function to specify if the code for a field should be generated even if it's omitempty and having the zero or default value. This was required for generation of enable_serverless_compute = false that is marked as omitempty

Fixes #3758

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott
[Exporter] Improve code generation for SQL Endpoints
bde47d2 
Changes include:

- Always generate `enable_serverless_compute` attribute for `databricks_sql_endpoint` and
  `databricks_sql_global_config` - this is required when there is a mix of serverless &
  non-serverless SQL endpoints
- Don't generate `channel` when it's empty or is current
- Don't generate `tags` block when there are no tags
- Importable can define `ShouldGenerateField` function to specify if the code for a field
  should be generated even if it's `omitempty` and having the zero or default value.  This
  was required for generation of `enable_serverless_compute = false` that is marked as
  `omitempty`

Fixes #3758
@alexott alexott requested review from a team as code owners July 13, 2024 08:35
@alexott alexott requested review from tanmay-db and removed request for a team July 13, 2024 08:35
@alexott alexott added the exporter TF configuration generator label Jul 16, 2024
@alexott alexott added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 9e8fd30 Jul 16, 2024
6 checks passed
@alexott alexott deleted the issue-3758 branch July 16, 2024 08:24
@alexott alexott mentioned this pull request Jul 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 19, 2024
@tanmay-db
[Release] v1.49.0 (#3752)
733c998 
## 1.49.0

### New Features and Improvements
* Added `databricks_dashboard` resource
([#3729](#3729)).
* Added `databricks_schema` data source
([#3732](#3732)).
* Added support for binding storage credentials and external locations
to specific workspaces
([#3678](#3678)).
* Added `databricks_volume` as data source
([#3211](#3211)).
* Make the `schedule.pause_status` field read-only
([#3692](#3692)).
* Renamed `databricks_catalog_workspace_binding` to
`databricks_workspace_binding`
([#3703](#3703)).
* Make `cluster_name_contains` optional in `databricks_clusters` data
source
([#3760](#3760)).
* Tolerate OAuth errors in databricks_mws_workspaces when managing
tokens
([#3761](#3761)).
* Permissions for `databricks_dashboard` resource
([#3762](#3762)).

### Exporter
* Emit directories during the listing only if they are explicitly
configured in `-listing`
([#3673](#3673)).
* Export libraries specified as `requirements.txt`
([#3649](#3649)).
* Fix generation of `run_as` blocks in `databricks_job`
([#3724](#3724)).
* Use Go SDK structs for `databricks_job` resource
([#3727](#3727)).
* Clarify use of `-listing` and `-services` options
([#3755](#3755)).
* Improve code generation for SQL Endpoints
([#3764](#3764))

### Documentation
* Fix invalid priviledges in grants.md
([#3716](#3716)).
* Update cluster.md: add data_security_mode parameters `NONE` and
`NO_ISOLATION`
([#3740](#3740)).
* Remove references to basic auth
([#3720](#3720)).
* Update resources diagram
([#3765](#3765)).

### Internal Changes
* Add Release tag
([#3748](#3748)).
* Improve Changelog by grouping changes
([#3747](#3747)).
* Change TF registry ownership
([#3736](#3736)).
* Refactored `databricks_cluster(s)` data sources to Go SDK
([#3685](#3685)).
* Upgrade databricks-sdk-go
([#3743](#3743)).
* Run goreleaser action in snapshot mode from merge queue
([#3646](#3646)).
* Make `dashboard_name` random in integration tests for
`databricks_dashboard` resource
([#3763](#3763)).
* Clear stale go.sum values
([#3768](#3768)).
* Add "Owner" tag to test cluster in acceptance test
([#3771](#3771)).
* Fix integration test for restrict workspace admins setting
([#3772](#3772)).
* Add "Owner" tag to test SQL endpoint in acceptance test
([#3774](#3774)).
* Move PR message validation to a separate workflow
([#3777](#3777)).
* Trigger the validate workflow in the merge queue
([#3782](#3782)).
* Update properties for managed SQL table on latest DBR
([#3784](#3784)).
* Add "Owner" tag to test SQL endpoint in acceptance test
([#3785](#3785)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkvuong nkvuong nkvuong approved these changes

@tanmay-db tanmay-db Awaiting requested review from tanmay-db tanmay-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
exporter TF configuration generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limitations - Specific Case for Serverless- DBSQL Serverless has been imported as a PRO instance
2 participants
@alexott @nkvuong