Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Use Databricks runners for GitHub Actions #4080

Closed
wants to merge 5 commits into from
Closed

[Internal] Use Databricks runners for GitHub Actions #4080

wants to merge 5 commits into from
+19 −7

Conversation

mgyucht
Copy link
Contributor

@mgyucht mgyucht commented Oct 9, 2024

Changes

As part of an internal effort to improve Databricks' security stance, all GitHub actions must use Databricks runners. This PR adopts this change for this repository.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@mgyucht mgyucht requested review from a team as code owners October 9, 2024 07:40
@mgyucht mgyucht requested review from renaudhartert-db and removed request for a team October 9, 2024 07:40
@mgyucht mgyucht enabled auto-merge October 9, 2024 10:03
@alexott alexott temporarily deployed to test-trigger-is December 2, 2024 11:28 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4080
  • Commit SHA: 96a1d76040d21ad28e55fda57f4b8b75755d1e31

Checks will be approved automatically on success.

@alexott alexott temporarily deployed to test-trigger-is December 2, 2024 11:28 — with GitHub Actions Inactive
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12118390832

@mgyucht mgyucht temporarily deployed to test-trigger-is January 6, 2025 09:21 — with GitHub Actions Inactive
@pietern pietern mentioned this pull request Jan 6, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 6, 2025
@pietern
[Internal] Migrate workflows that need write access to use hosted run…
9f7bebe 
…ners (#4377)

Fixes #4376.

Supersedes #4080.

Note: the YAML files were unformatted; please review with "hide
whitespace".
@mgyucht mgyucht closed this Jan 7, 2025
auto-merge was automatically disabled January 7, 2025 16:27

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaudhartert-db renaudhartert-db renaudhartert-db approved these changes

@hectorcast-db hectorcast-db hectorcast-db approved these changes

@alexott alexott alexott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mgyucht @eng-dev-ecosystem-bot @alexott @hectorcast-db @renaudhartert-db