Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add fallback to databricks_external_location #4372

Merged
merged 2 commits into from
Jan 3, 2025
Merged

[Feature] Add fallback to databricks_external_location #4372

merged 2 commits into from
Jan 3, 2025

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jan 3, 2025

Changes

To support the new feature, I switched to the use of Go SDK instead of a manually crafted structure.

Resolves #4369

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@alexott
[Feature] Add fallback to databricks_external_location
b39eead 
To support new feature I switched to use of Go SDK instead of manually crafted structure.
@alexott alexott requested review from a team as code owners January 3, 2025 10:44
@alexott alexott requested review from renaudhartert-db and removed request for a team January 3, 2025 10:44
@alexott alexott temporarily deployed to test-trigger-is January 3, 2025 10:45 — with GitHub Actions Inactive
@alexott alexott temporarily deployed to test-trigger-is January 3, 2025 10:45 — with GitHub Actions Inactive
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12596520336

mgyucht
mgyucht approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question, otherwise looks good to me!

catalog/resource_external_location.go Show resolved Hide resolved
docs/resources/external_location.md Outdated Show resolved Hide resolved
@alexott alexott temporarily deployed to test-trigger-is January 3, 2025 14:08 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4372
  • Commit SHA: 8f091650eab542f6f17506ae70cef21257ae42e2

Checks will be approved automatically on success.

@alexott alexott temporarily deployed to test-trigger-is January 3, 2025 14:08 — with GitHub Actions Inactive
@alexott alexott added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit b15e372 Jan 3, 2025
12 checks passed
@alexott alexott deleted the feature/fallback-mode-in-external-location branch January 3, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

@renaudhartert-db renaudhartert-db Awaiting requested review from renaudhartert-db renaudhartert-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support specifying fallback in databricks_external_location
3 participants
@alexott @eng-dev-ecosystem-bot @mgyucht