Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publisher TypeError on MetaData Export #845

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Conversation

kaysiz
Copy link
Contributor

@kaysiz kaysiz commented Jan 30, 2024

Purpose

Exporting Metadata fails because of a nil publisher

closes: #844

Approach

Add conditional check for publisher before accessing its name

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@kaysiz kaysiz self-assigned this Jan 30, 2024
@kaysiz kaysiz requested a review from a team January 30, 2024 14:46
@kaysiz kaysiz requested a review from codycooperross January 30, 2024 16:46
@kaysiz kaysiz merged commit c9213e8 into main Jan 30, 2024
5 checks passed
@kaysiz kaysiz deleted the fix-metadata-export branch January 30, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: null is not an object (evaluating 'e.publisher.name')
2 participants