humanize account_type text. #475

app/models/concerns/mailable.rb

@@ -28,7 +28,7 @@ def send_welcome_email
       reset_url = ENV['BRACCO_URL'] + "/reset"
       title = Rails.env.stage? ? "DataCite Fabrica Test" : "DataCite Fabrica"
       subject = "#{title}: New Account"
-      account_type = self.class.name == "Provider" ? member_type : client_type
+      account_type = self.class.name == "Provider" ? member_type.humanize : client_type.humanize
       text = User.format_message_text(template: "users/welcome.text.erb", title: title, contact_name: name, name: symbol, url: url, reset_url: reset_url)
       html = User.format_message_html(template: "users/welcome.html.erb", title: title, contact_name: name, name: symbol, url: url, reset_url: reset_url)
 
@@ -48,7 +48,7 @@ def send_welcome_email
     def send_delete_email
       title = Rails.env.stage? ? "DataCite Fabrica Test" : "DataCite Fabrica"
       subject = "#{title}: Account Deleted"
-      account_type = self.class.name == "Provider" ? member_type : client_type
+      account_type = self.class.name == "Provider" ? member_type.humanize : client_type.humanize
       text = User.format_message_text(template: "users/delete.text.erb", title: title, contact_name: name, name: symbol)
       html = User.format_message_html(template: "users/delete.html.erb", title: title, contact_name: name, name: symbol)
 

spec/concerns/mailable_spec.rb

@@ -2,7 +2,7 @@
 
 describe "Mailable", type: :model, vcr: true do
   let(:token) { User.generate_token }
-  let(:provider) { create(:provider, symbol: "DATACITE") }
+  let(:provider) { create(:provider, symbol: "DATACITE", name: "DataCite", system_email: "[email protected]") }
   let(:client) { create(:client, symbol: "DATACITE.DATACITE", name: "DataCite Repository", system_email: "[email protected]", provider: provider) }
   let(:title) { "DataCite Fabrica" }
 
@@ -55,4 +55,12 @@
       expect(Client.send_notification_to_slack(text, options)).to eq("ok")
     end
   end
+
+  context "send_notification_to_slack provider" do
+    it "succeeds" do
+      text =  "Using system email #{provider.system_email}."
+      options = { title: "TEST: new provider account #{provider.symbol} created." }
+      expect(Client.send_notification_to_slack(text, options)).to eq("ok")
+    end
+  end
 end