Skip to content

Commit

Permalink
set up services. #681
Browse files Browse the repository at this point in the history
  • Loading branch information
Martin Fenner committed Nov 22, 2020
1 parent 4272efa commit 0ebbe8d
Show file tree
Hide file tree
Showing 4 changed files with 44 additions and 24 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ jobs:
test:
runs-on: ubuntu-latest
env:
ELASTIC_PASSWORD: changeme
MEMCACHE_SERVERS: "localhost:11211"
MYSQL_HOST: "localhost:3306"
ES_HOST: "localhost:9200"
ELASTIC_PASSWORD: "changeme"
services:
memcached:
image: memcached:1.4.31
Expand Down
2 changes: 1 addition & 1 deletion spec/concerns/wikidatable_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
context "find_by_wikidata_id" do
it "for entity" do
id = "Q35794"
result = subject.find_by(wikidata_id: id)
result = subject.find_by_wikidata_id(id)
organization = result[:data].first

expect(organization.id).to eq("Q35794")
Expand Down
58 changes: 37 additions & 21 deletions spec/fixtures/vcr_cassettes/Person/wikidata_query/employment.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion spec/models/other_doi_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

require "rails_helper"

describe OtherDoi, type: :model, vcr: true do
describe OtherDoi, type: :model do
it_behaves_like "an STI class"

describe "import_by_ids", elasticsearch: true do
Expand All @@ -18,6 +18,7 @@

it "import by id" do
response = OtherDoi.import_by_id(id: doi.id)
sleep 2
expect(response).to eq(3)
end
end
Expand Down

0 comments on commit 0ebbe8d

Please sign in to comment.